Improve pbr example (confusing comment) #16996
Open
+6
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
After a recent fix for a panic in the pbr example (#16976), the code contains the following comment:
However, this explanation is incorrect.
EnvironmentMapLabel
is available at start. The real issue is that it is no longer available once it has been removed byenvironment_map_load_finish
.Solution
never_param_warn()
.Single<Entity, With<EnvironmentMapLabel>>
optional inenvironment_map_load_finish
, and check that the entity has not yet been despawned.Since it is expected that an entity is no longer there once it has been despawned, it seems better to me to handle this case in
environment_map_load_finish
.Testing
Ran
cargo run --example pbr
.