feat(meditrak): RN-502: Switch meditrak-app over to the meditrak-app-server #5007

rohan-bes · 2023-09-19T05:37:46Z

Issue RN-502:

This is the big switch over! Might be easiest to review commit by commit.

Main thing to be aware of here is that we're doing a switch over of api.tupaia.org to now point to the meditrak-app-server. That way existing meditrak-app clients can switch over without needing to upgrade.

We will now server central-server at central-api.tupaia.org.

Merge tasks:

Update all CENTRAL_API_URL .env vars to point to *-central-api.tupaia.org
Update the subdomains ec2 instance tag to include central-api and create the route53 entry for production
Remove TUPAIA_APP_SERVER_URL .env var from web-config-server .env vars

IgorNadj · 2023-09-21T03:44:25Z

packages/devops/scripts/deployment/startBackEnds.sh

+            cd ${TUPAIA_DIR}
+
+            # ensure that the latest permissions based meditrak sync queue has been built
+            yarn workspace @tupaia/meditrak-app-server create-meditrak-sync-view


Should this be moved to the server's startup instead? Similar to how we do migrations.

Discussed, could version and insert with migrations like we do the analytics table fns.

@IgorNadj I've created a separate PR for this one: #5063

IgorNadj · 2023-09-21T04:02:32Z

packages/meditrak-app-server/src/index.ts

@@ -10,7 +10,6 @@ import http from 'http';
 import winston from 'winston';


(Unrelated to this file)
In package.json we have a script that calls node dist/sync/createMeditrakSyncView.js. The dist files for this may not be present. Can we use babel-node like we do in other packages for consistency? This also seems like a script so it should be outside the src dir.

Done in: #5063

scripts/bash/getDeployablePackages.sh

IgorNadj · 2023-09-21T04:06:19Z

packages/central-server/src/apiV2/meditrakApp/getChanges.js

@@ -1,112 +0,0 @@
-/**


Soooo good to see all this moved out! Thanks for doing this!

IgorNadj

Just the things we found when we went through it together, otherwise looks great!

...s/database/src/migrations/20230926070127-MoveRefreshTokenToMeditrakDevice-modifies-schema.js

packages/meditrak-app-server/src/__tests__/__integration__/appVersion.test.ts

...meditrak-app-server/src/__tests__/__integration__/sync/pullChanges/CountChangesRoute.test.ts

packages/meditrak-app-server/src/routes/AuthRoute.ts

packages/meditrak-app-server/src/routes/sync/PushChangesRoute/PushChangesRoute.ts

…-server can support v1 or v2 (for legacy app versions)

merge: update branch with latest dev before testing

…ontend

… column if updating

…tId provided

merge: update with latest dev before testing

rohan-bes changed the title ~~Rn 502 switch to mas~~ RN-502: Switch meditrak-app over to the meditrak-app-server Sep 19, 2023

rohan-bes force-pushed the rn-664-perm-based-sync-mas branch from 006ef72 to 3eb2b8d Compare September 19, 2023 07:40

rohan-bes force-pushed the rn-502-switch-to-mas branch from ccdc34a to c0075d4 Compare September 19, 2023 07:42

IgorNadj reviewed Sep 21, 2023

View reviewed changes

rohan-bes force-pushed the rn-502-switch-to-mas branch 4 times, most recently from 4b923ce to 26afa79 Compare October 2, 2023 05:19

rohan-bes force-pushed the rn-664-perm-based-sync-mas branch from 3eb2b8d to fcd049f Compare October 2, 2023 06:01

rohan-bes force-pushed the rn-502-switch-to-mas branch from 26afa79 to 1ed8754 Compare October 2, 2023 06:05

Base automatically changed from rn-664-perm-based-sync-mas to dev October 10, 2023 00:39

rohan-bes force-pushed the rn-502-switch-to-mas branch from 1ed8754 to 72d9f0b Compare October 10, 2023 02:12

rohan-bes mentioned this pull request Oct 10, 2023

RN-502: Move building of permissions based meditrak sync queue to a database function #5063

Merged

rohan-bes force-pushed the rn-502-switch-to-mas branch from 72d9f0b to cd37231 Compare October 10, 2023 05:11

rohan-bes changed the base branch from dev to rn-502-remove-schema-async October 10, 2023 05:14

rohan-bes requested a review from IgorNadj October 10, 2023 06:32

rohan-bes force-pushed the rn-502-switch-to-mas branch 2 times, most recently from d07b697 to 00e88b3 Compare October 12, 2023 05:53

rohan-bes force-pushed the rn-502-remove-schema-async branch from 3f0a66b to 56125db Compare October 12, 2023 23:46

Base automatically changed from rn-502-remove-schema-async to dev October 16, 2023 03:29

rohan-bes force-pushed the rn-502-switch-to-mas branch 3 times, most recently from 432eff9 to 94f790e Compare October 19, 2023 00:22

IgorNadj suggested changes Oct 23, 2023

View reviewed changes

rohan-bes force-pushed the rn-502-switch-to-mas branch 5 times, most recently from 6d9955d to 8235a10 Compare March 26, 2024 04:04

rohan-bes force-pushed the rn-502-switch-to-mas branch from 8235a10 to dbe2a47 Compare March 28, 2024 05:10

rohan-bes added 7 commits April 30, 2024 17:06

RN-502: Added missing requestCountryAccess endpoint

182fa69

RN-502: Added missing deleteAccount endpoint

db28731

RN-502: Fixed error message formatting

17a0718

RN-502: Fix creating options

871d046

RN-502: Fixed validation for entity.attributes

ffba055

RN-502: Fixed tests

8e4206f

RN-502: Removed data_time reformatting

35054ff

rohan-bes force-pushed the rn-502-switch-to-mas branch from 216b020 to 35054ff Compare May 2, 2024 23:59

rohan-bes and others added 16 commits May 3, 2024 10:39

Merge branch 'dev' into rn-502-switch-to-mas

57cd760

RN-502: Added support for allowing version regex so that meditrak-app…

44ce65c

…-server can support v1 or v2 (for legacy app versions)

Merge branch 'dev' into rn-502-switch-to-mas

400936a

Merge pull request #5631 from beyondessential/dev

dc2c46a

merge: update branch with latest dev before testing

RN-502: Fix tests

1d0da04

Merge branch 'dev' into rn-502-switch-to-mas

a2aa5cd

Merge branch 'dev' into rn-502-switch-to-mas

358f39c

Merge branch 'dev' into rn-502-switch-to-mas

6eb0bb1

Merge branch 'dev' into rn-502-switch-to-mas

e2bd786

RN-502: Fix tests

19c7f17

RN-502: Remove better-ajv-errors to allow including tsutils in the fr…

4586077

…ontend

Merge branch 'dev' into rn-502-switch-to-mas

38297e1

RN-502: Fix up constraint on meditrak_device table

baf1f6e

RN-502: Change survey response entity upsert to not override metadata…

a797c34

… column if updating

RN-502: Improve performance of calculating leaderboard when no projec…

0618ce1

…tId provided

RN-502: Added UserRewardsRoute to datatrak-web-server

89bf033

rohan-bes force-pushed the rn-502-switch-to-mas branch from cccf67c to 89bf033 Compare June 17, 2024 04:21

rohan-bes added 2 commits June 17, 2024 15:18

Merge branch 'dev' into rn-502-switch-to-mas

fb47ec8

RN-502: Fixed tests after merge

a502fed

rohan-bes force-pushed the rn-502-switch-to-mas branch from 9037bf7 to a502fed Compare June 19, 2024 02:29

avaek and others added 2 commits June 24, 2024 10:56

Merge pull request #5745 from beyondessential/dev

ef6e671

merge: update with latest dev before testing

RN-502: Renamed migrations to get them to run

0bdba45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(meditrak): RN-502: Switch meditrak-app over to the meditrak-app-server #5007

feat(meditrak): RN-502: Switch meditrak-app over to the meditrak-app-server #5007

rohan-bes commented Sep 19, 2023 •

edited

Loading

IgorNadj Sep 21, 2023

IgorNadj Sep 21, 2023

rohan-bes Oct 10, 2023

IgorNadj Sep 21, 2023

rohan-bes Oct 10, 2023

IgorNadj Sep 21, 2023

IgorNadj left a comment

		@@ -10,7 +10,6 @@ import http from 'http';
		import winston from 'winston';

feat(meditrak): RN-502: Switch meditrak-app over to the meditrak-app-server #5007

Are you sure you want to change the base?

feat(meditrak): RN-502: Switch meditrak-app over to the meditrak-app-server #5007

Conversation

rohan-bes commented Sep 19, 2023 • edited Loading

Issue RN-502:

Merge tasks:

IgorNadj Sep 21, 2023

Choose a reason for hiding this comment

IgorNadj Sep 21, 2023

Choose a reason for hiding this comment

rohan-bes Oct 10, 2023

Choose a reason for hiding this comment

IgorNadj Sep 21, 2023

Choose a reason for hiding this comment

rohan-bes Oct 10, 2023

Choose a reason for hiding this comment

IgorNadj Sep 21, 2023

Choose a reason for hiding this comment

IgorNadj left a comment

Choose a reason for hiding this comment

rohan-bes commented Sep 19, 2023 •

edited

Loading