style(datatrakWeb): RN-1448: Responsive styling for landing page #5938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaskfla
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Have to admit I’ve mostly reviewed for readability; haven’t had the chance to pull the code and run it because I’m a bit time-constrained this week (and been a while since I last ran Tupaia)
Looks really great overall! A flurry of suggestions for possible minor improvements from me—the biggest one being how to handle components that have a mobile and desktop version. Otherwise mostly trivial details, so pre-approving 🍾
packages/datatrak-web/src/views/LandingPage/ActivityFeedSection/MobileActivityFeed.tsx
Show resolved
Hide resolved
packages/datatrak-web/src/views/LandingPage/ResponsiveScrollBody.tsx
Outdated
Show resolved
Hide resolved
merge: update branch with latest dev
merge: update branch with latest dev
merge: update branch with latest dev before testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue RN-1448: Responsive styling for landing page
Changes:
Screenshots: