feat(datatrak): RN-1528: DataTrak PWA Welcome Screens #6030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcaiger
changed the title
jaskfla
approved these changes
Dec 20, 2024
| * Copyright (c) 2017 - 2024 Beyond Essential Systems Pty Ltd | ||
| */ | ||
|
|
||
| function getPWADisplayMode() { |
There was a problem hiding this comment.
Bit less ambiguous to treat PWA as a “word” in camel case. (Unfortunate that web APIs capitalise entire abbreviations 🥲)
Suggested change
| function getPWADisplayMode() { | |
| function getPwaDisplayMode() { |
Comment on lines
+21
to
+23
| getPWADisplayMode() === 'standalone' || | ||
| getPWADisplayMode() === 'fullscreen' || | ||
| getPWADisplayMode() === 'minimal-ui' |
There was a problem hiding this comment.
I presume you meant to use displayMode here?
Suggested change
| getPWADisplayMode() === 'standalone' || | |
| getPWADisplayMode() === 'fullscreen' || | |
| getPWADisplayMode() === 'minimal-ui' | |
| displayMode === 'standalone' || | |
| displayMode === 'fullscreen' || | |
| displayMode === 'minimal-ui' |
| variant: 'h1', | ||
| })` | ||
| font-size: 1rem; | ||
| margin-bottom: 1rem; |
There was a problem hiding this comment.
Suggested change
| margin-bottom: 1rem; | |
| margin-block-end: 1rem; |
There was a problem hiding this comment.
I’d also suggest text-wrap: balance on <Title> and <Text>
| const Dot = styled.button<{ $active: boolean }>` | ||
| width: 0.5rem; | ||
| height: 0.5rem; | ||
| border-radius: 50%; |
There was a problem hiding this comment.
Doesn’t matter so much here because the width and height are hard-coded to be square, but using % values usually yields unwanted oval-ish results. This is a little more broadly applicable:
Suggested change
| border-radius: 50%; | |
| border-radius: calc(infinity * 1px); |
| const steps = [ | ||
| { | ||
| title: 'Welcome to Tupaia DataTrak!', | ||
| text: "If you're here from MediTrak, welcome! Rest assured that you have all the same functionality as MediTrak, only better. Come for a quick tour of what's new.", |
There was a problem hiding this comment.
Suggested change
| text: "If you're here from MediTrak, welcome! Rest assured that you have all the same functionality as MediTrak, only better. Come for a quick tour of what's new.", | |
| text: 'If you’re here from MediTrak, welcome! Rest assured that you have all the same functionality as MediTrak, only better. Come for a quick tour of what’s new.', |
| }, | ||
| { | ||
| title: 'Projects', | ||
| text: "From the home screen you can see which project you're in. Click on the project to swap to a different project.", |
There was a problem hiding this comment.
Suggested change
| text: "From the home screen you can see which project you're in. Click on the project to swap to a different project.", | |
| text: 'From the home screen you can see which project you’re in. Click on the project to swap to a different project.', |
| imgPath: 'images/data-collection-woman.svg', | ||
| }, | ||
| { | ||
| title: 'Sync Status', |
There was a problem hiding this comment.
Suggested change
| title: 'Sync Status', | |
| title: 'Sync status', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: RN-1528: DataTrak PWA Welcome Screens
Changes:
user_account->preferencesin the DB using a new key calledhide_welcome_screenScreenshots: