[BB-248] Improving test coverage #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Franr
commented
Feb 25, 2024
| fetch_mfa_device (bool): Whether to fetch MFA device for profiles. | ||
| """ | ||
| short_name, type = profile.split("-") |
There was a problem hiding this comment.
type is a built-in function, better not to shadow it 🙂
borland667
reviewed
Mar 11, 2024
Comment on lines
86
to
90
| def test_configure_accounts_profiles(mocked_backup, mfa_device, muted_click_context): | ||
| """ | ||
| Test that the expected jsons for the aws credentials are generated as expected. | ||
| Cover both mfa and no-mfa cases. | ||
| """ |
There was a problem hiding this comment.
@Franr I'd split these tests and have a separate test for each case.
|
@Franr General question. Perhaps I'm not familiar with the code yet but I'm finding it hard to understand what are you trying to test with some of the methods that do not describe what you are trying to test. Can we add docstrings with descriptions to all tests so its clear what is the intent ? |
borland667
reviewed
Mar 11, 2024
borland667
approved these changes
Apr 8, 2024
juanmatias
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Improving tests coverage, mostly around
modules/credentialsSeparating GHA files into 2: we need the "push" event for the unit tests, for the coverage integration, but not on the integration ones.
Why?
To improve the tools quality/realiability!
References
https://coveralls.io/builds/66184725