API: allow specifying an ASV to use as a control #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've reviewed everything here. Looks good. I know some people have expressed interest in specifying a CUSTOM taxonomy rather than ASV to use as control. From the changes it looks like this would be immediately possible now. |
|
Thanks!
… On Jan 16, 2024, at 5:45 PM, Daniela Perry ***@***.***> wrote:
Merged #13 <https://urldefense.com/v3/__https://github.com/biocore/q2-katharoseq/pull/13__;!!Mih3wA!Hm427CAIZxngX1rQPYZqFkUdRg6XVSdx73h5NHHrAR-61lz_Uj3dvHiHayhNWeSRaswVxn_WmkAMqgXSf2KgHU1iE0Q2XvISLU_P0Q$> into master.
—
Reply to this email directly, view it on GitHub <https://urldefense.com/v3/__https://github.com/biocore/q2-katharoseq/pull/13*event-11505531804__;Iw!!Mih3wA!Hm427CAIZxngX1rQPYZqFkUdRg6XVSdx73h5NHHrAR-61lz_Uj3dvHiHayhNWeSRaswVxn_WmkAMqgXSf2KgHU1iE0Q2XvJ65EFH2Q$>, or unsubscribe <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AADTZMTUHKBRV6IIF2FKLSLYO4ULVAVCNFSM6AAAAABB5T6N6WVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGUYDKNJTGE4DANA__;!!Mih3wA!Hm427CAIZxngX1rQPYZqFkUdRg6XVSdx73h5NHHrAR-61lz_Uj3dvHiHayhNWeSRaswVxn_WmkAMqgXSf2KgHU1iE0Q2XvKpWDCHuA$>.
You are receiving this because you authored the thread.
|
|
Hey @dpear, would it be possible to do a release of the plugin to include this? if other issues / PRs are easy to close out, then that would be good to also do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...per the subject, the idea here is to use an ASV rather than taxonomy to act as the control