Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

taproot payload with own pubkey #30

Merged
merged 9 commits into from
Sep 24, 2024
Merged

taproot payload with own pubkey #30

merged 9 commits into from
Sep 24, 2024

Conversation

veeso
Copy link
Member

@veeso veeso commented Sep 24, 2024

  • feat: build taproot with external pubkey
  • fix: added derivation path
  • fix: ecdsa pubkey should return res
  • fix: custom error
  • fix: schnorr_public_key name
  • fix: further tests

Motivation

Closes #

Changes

Test Plan

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed

DevOps Notes

  • This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
  • This PR does not affect public APIs
  • This PR does not rely on a new version of external services
  • This PR does not make changes to log messages (which monitoring infrastructure may rely on)

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@veeso veeso merged commit 887e74e into main Sep 24, 2024
6 checks passed
@veeso veeso deleted the taproot-payload-with-own-pubkey branch September 24, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@veeso