Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag n Drop new logo #212

Merged
merged 5 commits into from
Jan 8, 2025
Merged

Conversation

sshiiden
Copy link
Member

Drag n Drop changes from blazium-assets/pull/37

Copy link
Member

@jss2a98aj jss2a98aj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests are failing due to the SVG size being larger than before. It may be possible to optimize the SVGs below the size threshold, but if not a value will need changed in one of the tests.

platform/android/java/editor/src/meta/assets/vr_splash.png Outdated Show resolved Hide resolved
@sshiiden sshiiden requested a review from jss2a98aj December 31, 2024 22:15
@sshiiden
Copy link
Member Author

The PNG splash images went over 60KB

Ughuuu
Ughuuu previously approved these changes Jan 7, 2025
jss2a98aj
jss2a98aj previously approved these changes Jan 7, 2025
@jss2a98aj
Copy link
Member

Can #123 be addressed here before this is merged if possible?

@sshiiden sshiiden dismissed stale reviews from jss2a98aj and Ughuuu via 692be21 January 7, 2025 22:20
jss2a98aj
jss2a98aj previously approved these changes Jan 7, 2025
@jss2a98aj jss2a98aj merged commit 187bb36 into blazium-engine:blazium-dev Jan 8, 2025
22 checks passed
@sshiiden sshiiden deleted the logo-change branch January 8, 2025 21:04
verypleasentusername added a commit to verypleasentusername/blazium that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants