Suppress non-virtual dtor error on IAudioClient3 #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ughuuu
approved these changes
Jan 9, 2025
jss2a98aj
approved these changes
Jan 9, 2025
Bioblaze
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
scons dev_mode=yesusing the MinGW compiler, the following error is produced:'struct IAudioClient3' has virtual functions and accessible non-virtual destructor [-Werror=non-virtual-dtor]This error is due to MinGW not understanding how Windows COM interfaces are used, and cannot be fixed on our end as it requires modifying Windows header files. This PR suppresses this error.