Fix incorrect terminal message after installation #4402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6b07506 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
siddhsuresh
approved these changes
Dec 23, 2024
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR resolves an issue in the terminal output after creating a new Blitz app. The post-installation steps currently suggest running:
npm blitz devThis command does not work as expected.
Fix:
Updated the source code to ensure the correct command is displayed, based on the package manager used. For npm, the correct command is:
npm run devThe updated logic now dynamically sets the command as follows:
postInstallSteps.push(${projectPkgManager} ${projectPkgManager === "npm" ? "run " : ""}dev);Impact:
This fix improves the developer experience by providing accurate and actionable post-installation instructions.
Closes: #4401