Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Redundant Coins #41

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

psavva
Copy link
Contributor

@psavva psavva commented Sep 1, 2022

Removed: HomeCoin, SerfNet, Solaris

Copy link
Member

@sondreb sondreb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "chains" JSON files should not be removed. Anyone running indexers for those chains, will stop working.

Will keep SERF running a little while more, got a few connections on it.

@psavva
Copy link
Contributor Author

psavva commented Sep 2, 2022

@sondreb Do you want to keep all 3 chains files or just that of SERF?

I will undo SERF in totality, and keep it as it was prior to this PR.
I will continue to remove HomeCoin and Solaris

@sondreb
Copy link
Member

sondreb commented Sep 2, 2022

Everything in the "chains" folder must be kept around for a long time. Can remove the docker setup for HOME and XLR, and also from the large .json files that is used to list in explorer. Thanks!

@psavva
Copy link
Contributor Author

psavva commented Sep 11, 2022

Hi @sondreb

Apologies for the delay in reverting back.
Chains.json has been restored to the version prior to this PR.

Please check if it's ok to merge :)

@psavva
Copy link
Contributor Author

psavva commented Sep 11, 2022

The block-core:master branch requires linear history

The base branch does not accept merge commits. Alternate merge methods are preferred. Learn more about required linear history.

Done

@sondreb
Copy link
Member

sondreb commented Sep 11, 2022

HOME.json and XLR.json cannot be deleted. If they are deleted, all indexers running for those chains will crash and fail, if they don't run with custom settings.

To clarify: If anyone in the world happens to spin up a HOME indexer, the indexer software will retrieve the HOME.json for configuration settings. It doesn't have to be shown in the official list on our explorer though, but we must keep those configuration files around for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants