Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid including an unexpected doctype in result #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gmichard
Copy link

@gmichard gmichard commented May 5, 2020

Fix the issue #4, using the following suggestion : #3 (comment).

Requires PHP 5.4.0 or more.

Since PHP 5.4.0 and Libxml 2.6.0, you may also use the options parameter
Source

@see bluetel#4 Fix this issue

> Since PHP 5.4.0 and Libxml 2.6.0, you may also use the options parameter

@see https://www.php.net/manual/en/domdocument.loadhtml.php Requires PHP 5.4.0 or more
@garak
Copy link

garak commented Jun 23, 2020

Can we merge this?

@ryanolee ryanolee added the needs review Awaiting on team member to review changes label Sep 4, 2020
@ryanolee
Copy link
Collaborator

Sorry for the late response on this one. Have been meaning to get this tested and merged in to the main line for a while but have since never had a chance. Will try to get this properly reviewed and tested later this week 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Awaiting on team member to review changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants