pevm: support parallel merge mode #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welkin22
requested review from
sunny2022da and
andyzhang2023
and removed request for
redhdx and
andyzhang2023
sunny2022da
reviewed
Dec 26, 2024
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, in our PEVM code, only the execution phase is parallelized. After the parallel execution ends, the results need to be merged serially into the StateDB. I have modified the merging process to be executed in parallel as well, which further improves the performance of the PEVM and reduces the time consumption.
Rationale
By providing a new ParallelStateDB to replace the original StateDB, it supports concurrent reading and writing of data.
Provide ParallelGasPool instead of the original GasPool to support gas calculation in a concurrent environment.
Other similar changes.
Example
Enable parallel merge mode by adding startup parameters:
Note that this startup parameter conflicts with parallel.unordered-merge, and when both are set, parallel.unordered-merge will be invalid.
Changes
Notable changes:
state.StateDBerinterface replaces direct references toStateDB.TestBlockchainWithTxDAGunit test. I found that the previous unit test had issues, as the code did not enter the branch that uses the DAG files.