-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upgrade traefik client library to support new resource packaging #159
Conversation
@borchero can you approve the workflow run? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
=======================================
Coverage 71.84% 71.84%
=======================================
Files 12 12
Lines 380 380
=======================================
Hits 273 273
Misses 88 88
Partials 19 19
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, CI passes 😍 do you know what exactly was the fix?
I don’t understand why it works now, I did not change related to that CI job since last week. |
Hello @borchero, now that the CI passes, can you take the lead on merging this MR and creating a new release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the effort @christian-vdz, this looks good to me! I don't think we need to continue supporting traffic.containo.us
(as discussed in #111) since this repo does not see too many changes 👀
Sorry about the long review period, I am not working with Traefik/Kubernetes at the moment and I briefly needed to catch up what exactly changed in Traefik that necessitates this change.
I'm briefly taking care of all the dependabot PRs and will publish a new release |
Here we go: https://github.com/borchero/switchboard/releases/tag/v0.6.0 😄 sorry again for the suboptimal maintenance recently. |
No worries, thank you for taking the time! |
Motivation
As it stands, Switchboard cannot work with newer versions of Traefik as describe in #111. This change patches the project to include the newer version of the Traefik client library allowing it to operate with newer versions of traefik.
Resolves #111
Explanation
This change upgrades the Traefik client library, patches the various files that use the Traefik, and finally updates the ClusterRole defined in the helm chart to support watching the appropriate resources.
Changes
Checklist