Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade traefik client library to support new resource packaging #159

Merged
merged 2 commits into from
Apr 7, 2024
Merged

fix: upgrade traefik client library to support new resource packaging #159

merged 2 commits into from
Apr 7, 2024

Conversation

christian-vdz
Copy link
Contributor

Motivation

As it stands, Switchboard cannot work with newer versions of Traefik as describe in #111. This change patches the project to include the newer version of the Traefik client library allowing it to operate with newer versions of traefik.

Resolves #111

Explanation

This change upgrades the Traefik client library, patches the various files that use the Traefik, and finally updates the ClusterRole defined in the helm chart to support watching the appropriate resources.

Changes

  • Patches go.mod
  • Updates library usage
  • Updates the kubernetes controller permissions.

Checklist

  • I added relevant tests
  • I have updated the documentation if necessary

@christian-vdz
Copy link
Contributor Author

@borchero can you approve the workflow run?

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Merging #159 (5365682) into main (7006eb4) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #159   +/-   ##
=======================================
  Coverage   71.84%   71.84%           
=======================================
  Files          12       12           
  Lines         380      380           
=======================================
  Hits          273      273           
  Misses         88       88           
  Partials       19       19           
Files Coverage Δ
internal/controllers/ingressroute.go 50.00% <ø> (ø)
internal/controllers/utils.go 59.09% <ø> (ø)
internal/switchboard/hosts.go 90.62% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7006eb4...5365682. Read the comment docs.

Copy link
Owner

@borchero borchero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, CI passes 😍 do you know what exactly was the fix?

justfile Outdated Show resolved Hide resolved
@christian-vdz
Copy link
Contributor Author

Nice, CI passes 😍 do you know what exactly was the fix?

I don’t understand why it works now, I did not change related to that CI job since last week.

@christian-vdz
Copy link
Contributor Author

Hello @borchero, now that the CI passes, can you take the lead on merging this MR and creating a new release?
I'd be happy to test it on my lab ASAP! ;)

Copy link
Owner

@borchero borchero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort @christian-vdz, this looks good to me! I don't think we need to continue supporting traffic.containo.us (as discussed in #111) since this repo does not see too many changes 👀

Sorry about the long review period, I am not working with Traefik/Kubernetes at the moment and I briefly needed to catch up what exactly changed in Traefik that necessitates this change.

@borchero borchero merged commit a93b99f into borchero:main Apr 7, 2024
12 checks passed
@borchero
Copy link
Owner

borchero commented Apr 7, 2024

I'm briefly taking care of all the dependabot PRs and will publish a new release 0.6.0 tonight :)

@borchero
Copy link
Owner

borchero commented Apr 7, 2024

Here we go: https://github.com/borchero/switchboard/releases/tag/v0.6.0 😄 sorry again for the suboptimal maintenance recently.

@christian-vdz
Copy link
Contributor Author

Here we go: https://github.com/borchero/switchboard/releases/tag/v0.6.0 😄 sorry again for the suboptimal maintenance recently.

No worries, thank you for taking the time!
I've tested it and it works 🥳

@christian-vdz christian-vdz deleted the gh-111 branch April 8, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for new API
3 participants