-
-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#6231: Clarify where paths are relative to #7737
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The recursion root is also named ``PATH`` in Borg commands like `borg create` | ||
that do a file discovery, so do not confuse the root with the ``PATH`` | ||
argument of e.g. `borg extract`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think this sentence is confusing. I'd vote for just deleting it, as I can't see how someone would confuse a recursion root with a path they want to extract. Or maybe just
The recursion root is also named ``PATH`` in Borg commands like `borg create` | |
that do a file discovery, so do not confuse the root with the ``PATH`` | |
argument of e.g. `borg extract`. | |
The recursion root is named ``PATH`` in Borg commands like `borg create` | |
that do file discovery. |
A documentation patch for #6231 clarifying where include/excludes are relative to. I changed the example to have two directories, to illustrate that the first (not second) directory is used.