Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hatch, Python 3.12, and more #440

Merged
merged 14 commits into from
Jul 29, 2024
Merged

Hatch, Python 3.12, and more #440

merged 14 commits into from
Jul 29, 2024

Conversation

ybastide
Copy link
Contributor

@ybastide ybastide commented Jul 4, 2024

Several things here:

  • (merged the hatch branch)
  • update moto and a test to work with Python 3.12
  • update pre-commit and ruff
  • improve SWFError to include the boto3 error code
  • create a WorkflowExecutionAlreadyStartedError exception

Signed-off-by: Yves Bastide yves@botify.com

@ybastide ybastide force-pushed the improvement/support-python-3.12 branch from 955b4c8 to c4c029c Compare July 4, 2024 16:46
ybastide added 9 commits July 5, 2024 17:23
Signed-off-by: Yves Bastide <yves@botify.com>
Remove now non-working, not useful tearDown.

Signed-off-by: Yves Bastide <yves@botify.com>
Signed-off-by: Yves Bastide <yves@botify.com>
Signed-off-by: Yves Bastide <yves@botify.com>
Signed-off-by: Yves Bastide <yves@botify.com>
Signed-off-by: Yves Bastide <yves@botify.com>
Translate WorkflowExecutionAlreadyStartedFault into
a WorkflowExecutionAlreadyStartedError exception.

Signed-off-by: Yves Bastide <yves@botify.com>
* add SWFError.error_code
* @translate: fill it when given a `ClientError` instance
* add unit test

Signed-off-by: Yves Bastide <yves@botify.com>
Add two lines useless in the CI 🙂

Signed-off-by: Yves Bastide <yves@botify.com>
@ybastide ybastide force-pushed the improvement/support-python-3.12 branch from c4c029c to eec242a Compare July 5, 2024 15:27
* error_code in ResponseError
* raise ... from
* modernize typing

Signed-off-by: Yves Bastide <yves@botify.com>
@ybastide ybastide marked this pull request as ready for review July 8, 2024 09:55
@ybastide ybastide changed the title Renaming the wip branch Hatch, Python 3.12, and more Jul 22, 2024
Signed-off-by: Yves Bastide <yves@botify.com>
@ybastide ybastide force-pushed the improvement/support-python-3.12 branch from 44172ca to 3bd497c Compare July 22, 2024 09:18
Signed-off-by: Yves Bastide <yves@botify.com>
@ybastide ybastide force-pushed the improvement/support-python-3.12 branch 2 times, most recently from ef8443f to 1f100d5 Compare July 26, 2024 13:43
Pin cffi to an RC for Python 3.13b.

Signed-off-by: Yves Bastide <yves@botify.com>
@ybastide ybastide force-pushed the improvement/support-python-3.12 branch from ed02741 to 44911a3 Compare July 26, 2024 14:21
Copy link
Contributor

@ewjoachim ewjoachim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice !

script/test Outdated Show resolved Hide resolved
Signed-off-by: Yves Bastide <yves@botify.com>
@ybastide ybastide merged commit c1dda3f into main Jul 29, 2024
9 checks passed
@ybastide ybastide deleted the improvement/support-python-3.12 branch July 29, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants