Improve resource deletion and update karpenter #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webern
approved these changes
Jan 26, 2024
ecpullen
force-pushed
the
resource-deletion
branch
from
03ff05d to
f8ea894
Compare
gthao313
approved these changes
Jan 29, 2024
ecpullen
force-pushed
the
resource-deletion
branch
2 times, most recently
from
a4add17 to
bb25590
Compare
ecpullen
changed the title
ecpullen
force-pushed
the
resource-deletion
branch
from
bb25590 to
5ca7174
Compare
ecpullen
force-pushed
the
resource-deletion
branch
from
5ca7174 to
76b3c76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
This adds a new finalizer to indicate that the creation job has started in case it is stopped in the middle of provisioning. If this situation occurs, the destroy job is then launched to attempt to cleanup any resource that were partially created.
Testing done:
Used the updated eks and karpenter agents to provision several clusters and ensure that no artifacts are left over after deletion.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.