feature/BE/415/get-user-info #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacettinburakeren
added
type : development
tacettinburakeren
requested review from
Hakkush-07,
omersafakbebek and
melihgezerr
|
your testa have failed, please check the pipeline @tacettinburakeren |
| @@ -179,4 +180,21 @@ export class UserService { | |||
| await this.userRepository.save(user); | |||
| return new ChangePasswordResponseDto(true); | |||
| } | |||
|
|
|||
| public async getUserInfo(userId: string): Promise<GetUserInfoResponseDto> { | |||
There was a problem hiding this comment.
It would be better if the user with all relations is fetched in one query since we will have additional relations. You can check this
| throw new NotFoundException('User not found'); | ||
| } | ||
|
|
||
| const response = new GetUserInfoResponseDto(); |
There was a problem hiding this comment.
Recently added user fields should be added also. These are not enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created get user information endpoint.