fix: remove zeebe:subscription if no properties left
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barmac
requested review from
a team,
philippfromme and
marstamm
and removed request for
a team
barmac
force-pushed
the
21-remove-subscription
branch
from
c05a8c3 to
bef7a4b
Compare
barmac
force-pushed
the
21-remove-subscription
branch
from
bef7a4b to
f490ca3
Compare
nikku
reviewed
Oct 16, 2023
| properties: { | ||
| [ binding.name ]: undefined | ||
| // remove subscription of none properties are left | ||
| if (noPropertiesLeft(subscription, binding.name)) { |
There was a problem hiding this comment.
The alternative is to handle this via a behavior, cf. camunda-bpmn-js-behaviors.
There was a problem hiding this comment.
Hmm perhaps it makes more sense. I declined this option initially because I thought it's an element-templates-only problem, but the cleanup is broken also in non-templated messages.
|
Closing this because we can solve the problem for all cases in the behaviors repo. Thanks for suggestion @nikku |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21