fix(Condition): use update logic for applying conditions #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marstamm
requested review from
philippfromme and
barmac
and removed request for
a team
barmac
reviewed
Dec 1, 2023
| this.preExecute([ 'propertiesPanel.zeebe.changeTemplate' ], HIGH_PRIORITY, this._applyCondtions , true, this); | ||
| } | ||
|
|
||
| _applyCondtions(context) { |
There was a problem hiding this comment.
Hmm this looks like a typo. There is _applyConditions already.
- _applyCondtions
+ _applyConditionsThere was a problem hiding this comment.
Whoops, let's get this fixed 😄
There was a problem hiding this comment.
Renamed to _handleTemplateUpgrade since it only applies for the change template handler
barmac
reviewed
Dec 1, 2023
Comment on lines
+39
to
+42
| // Event does not have an event definition | ||
| if (!bo) { | ||
| return; | ||
| } |
barmac
requested changes
Dec 1, 2023
bpmn-io-tasks
bot
added
in progress
bpmn-io-tasks
bot
added
needs review
barmac
approved these changes
Dec 4, 2023
nikku
reviewed
Dec 5, 2023
| @@ -78,8 +80,8 @@ describe('provider/cloud-element-templates - ElementTemplatesConditionChecker', | |||
| // then | |||
| expect(businessObject.get('customProperty')).to.exist; | |||
|
|
|||
| expect(businessObject.get('noDefaultProperty')).to.exist; | |||
There was a problem hiding this comment.
Let's clearly document this change in behavior. I believe we agreed this is a bug fix?
nikku
reviewed
Dec 5, 2023
| @@ -372,8 +374,7 @@ describe('cloud-element-templates/cmd - ChangeElementTemplateHandler', function( | |||
|
|
|||
| const taskDefinition = findExtension(task, 'zeebe:TaskDefinition'); | |||
|
|
|||
| expect(taskDefinition).to.exist; | |||
There was a problem hiding this comment.
Let's clearly document this change in behavior. I believe we agreed this is a bug fix?
|
This seems to ship to other hidden bug fixes ⬆️. Let's ensure they are marked as such in the CHANGELOG. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #32
propertyandMessagebindings