Field length error message #95
Conversation
holygeek00
requested review from
a team,
marstamm and
barmac
and removed request for
a team
There was a problem hiding this comment.
The PR includes 72d7755 even though it's not related to the linked issue. If a pull request depends on another PR, we mark this as "Requires #xx", e.g. https://github.com/bpmn-io/build-on-demand/pull/41#issuecomment-2095889208
|
Requires camunda/camunda-modeler#4207 |
bpmn-io-tasks
bot
added
in progress
holygeek00
force-pushed
the
Field_length_error_message
branch
from
67cc706 to
3e8c0f5
Compare
| @@ -1564,7 +1564,7 @@ describe('provider/cloud-element-templates - CustomProperties', function() { | |||
| input = domQuery(selector, entry); | |||
|
|
|||
| // assume | |||
| expectError(entry, `${name} - MinLength must have min length 5.`); | |||
|
@holygeek00 @marstamm What do you think about the proposed error message? What I liked about the old one is that we do proper casing |
|
Cf. also @barmac's prior investigations - camunda/camunda-modeler#4207 (comment). Could be worth do do a poll in the team channel to quickly agree on a direction to take. |
|
I agree, the naming is odd. We should either make it short and precise ("Use at least X Characters") or clean up the error message ("<PropertyName> must be at least X Characters"). The additional |
Related to camunda/camunda-modeler#4207