Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement formFieldInstanceRegistry #1143

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

Skaiir
Copy link
Contributor

@Skaiir Skaiir commented Apr 10, 2024

Closes #1142

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Apr 10, 2024
@Skaiir Skaiir marked this pull request as draft April 10, 2024 19:04
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Apr 10, 2024
@Skaiir Skaiir force-pushed the 1142-formField-instance-registry branch from 72eb29c to 7f1e7ed Compare April 11, 2024 06:33
@Skaiir Skaiir force-pushed the 1142-formField-instance-registry branch from 7f1e7ed to 59d7da6 Compare April 11, 2024 06:54
@Skaiir Skaiir force-pushed the 1142-formField-instance-registry branch from d421736 to 18f7c49 Compare April 11, 2024 07:38
@Skaiir Skaiir marked this pull request as ready for review April 11, 2024 07:42
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Apr 11, 2024
@Skaiir Skaiir merged commit cd4a4d5 into develop Apr 12, 2024
13 of 15 checks passed
@Skaiir Skaiir deleted the 1142-formField-instance-registry branch April 12, 2024 07:04
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Apr 12, 2024

return filteredErrors;
// @ts-ignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Skaiir Can we fix the types instead of ignoring them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a better way to work with individual formField instances
3 participants