Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] Add Telemetry Service #126

Merged
merged 2 commits into from
Jul 15, 2024
Merged

[enh] Add Telemetry Service #126

merged 2 commits into from
Jul 15, 2024

Conversation

bendhouseart
Copy link
Contributor

This PR adds a very simple API that enables pushing of json's to a mongodb with curl, this is a draft as it may make more sense to place this functionality somewhere else in the code base.

@bendhouseart
Copy link
Contributor Author

@dlevitas I moved telemetry out from the handler into it's own thing, which made more sense to me earlier today. However, now I'm not so sure, hence the drafty nature of this PR. Will tag you once I think over this and push some more changes.

Have a good weekend!

@dlevitas
Copy link
Collaborator

@bendhouseart this all looks good to me thus far. Thanks for this!

@bendhouseart bendhouseart marked this pull request as ready for review July 15, 2024 17:03
@bendhouseart
Copy link
Contributor Author

bendhouseart commented Jul 15, 2024

Okay, made it so that we don't break anything in production by adding telemetry to a development profile. It shouldn't impact anything when started from dev.sh or without --profile development appended to the docker compose command.

I think this gets you in a decent place for testing and can be merged.

@dlevitas ready for review.

@dlevitas dlevitas merged commit 3cdcdb9 into brainlife:master Jul 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants