Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AJ-1854 add concurrency groups to GH workflows #1373

Merged
merged 12 commits into from
Jun 18, 2024

Conversation

calypsomatic
Copy link
Contributor

@calypsomatic calypsomatic commented Jun 13, 2024

https://broadworkbench.atlassian.net/browse/AJ-1854

Adds concurrency groups to 3 workflows that run for pull requests. Runs them only on pull_request, not also on push. The one that creates a bee already uses always() for bee-destroy so there shouldn't be any rogue bees left lying around - verified by canceling after the bee had been created and saw that bee-destroy was run.

Have you read CONTRIBUTING.md lately? If not, do that first.

I, the developer opening this PR, do solemnly pinky swear that:

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've updated the RC_XXX release ticket with any manual steps required to release this change
  • I've updated the FISMA documentation if I've made any security-related changes, including auth, encryption, or auditing

In all cases:

  • Get two thumbsworth of review and PO signoff if necessary
  • Verify all tests go green
  • Squash and merge; you can delete your branch after this unless it's for a hotfix. In that case, don't delete it!
  • Test this change deployed correctly and works on dev environment after deployment

@calypsomatic calypsomatic changed the title Update unittest.yml AJ-1854 add concurrency groups to GH workflows Jun 14, 2024
@calypsomatic calypsomatic marked this pull request as ready for review June 14, 2024 13:28
@calypsomatic calypsomatic requested a review from a team June 14, 2024 13:29
Copy link
Contributor

@davidangb davidangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all three of these workflows should run on push to develop, which probably changes the invocation for the group value

@calypsomatic calypsomatic requested a review from davidangb June 18, 2024 14:14
@calypsomatic calypsomatic merged commit af37754 into develop Jun 18, 2024
12 checks passed
@calypsomatic calypsomatic deleted the aj-1854-concurrency branch June 18, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants