-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AOU deliverables doc updates [VS-1073] #8551
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of small changes
Co-authored-by: Bec Asch <rsasch@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits, otherwise looks good.
Apparently I can only "Comment" and not "Approve" probably because it's my own PR... 😄
- Run the steps in the notebook: | ||
- In section 1.2, Set the `sample_list_file_path` variable in that notebook to the path of the file | ||
- Run the cells up to and through, section 1.4 ("Perform the copy, in batches") | ||
- If you want to automatically break up the new samples into smaller sample sets, then run the "now that the data have been copied, you can make sample sets if you wish" step. Set the `SUBSET_SIZE` and `set_name` variables to customize. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this something we need to do and not really an "If"? Are there particular values that are known to work well for those variables?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! 👍🏻
Co-authored-by: Miguel Covarrubias <mcovarr@users.noreply.github.com>
Co-authored-by: Miguel Covarrubias <mcovarr@users.noreply.github.com>
Includes changes for
I did not make changes for the “Fetch WGS metadata” notebook as George is actively working through that in VS-1089. We can either fold those changes into this PR or have a follow-on PR as appropriate.