Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AOU deliverables doc updates [VS-1073] #8551

Merged
merged 14 commits into from
Oct 24, 2023

Conversation

mcovarr
Copy link
Collaborator

@mcovarr mcovarr commented Oct 12, 2023

Includes changes for

  • Hail clusters from WDL rather than notebooks
  • Delivering directly to an AoU bucket rather than reliving that STS nightmare

I did not make changes for the “Fetch WGS metadata” notebook as George is actively working through that in VS-1089. We can either fold those changes into this PR or have a follow-on PR as appropriate.

Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of small changes

scripts/variantstore/docs/aou/AOU_DELIVERABLES.md Outdated Show resolved Hide resolved
scripts/variantstore/docs/aou/AOU_DELIVERABLES.md Outdated Show resolved Hide resolved
scripts/variantstore/docs/aou/AOU_DELIVERABLES.md Outdated Show resolved Hide resolved
gbggrant and others added 2 commits October 17, 2023 13:38
@gbggrant gbggrant requested a review from rsasch October 17, 2023 17:44
Copy link
Collaborator Author

@mcovarr mcovarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, otherwise looks good.

Apparently I can only "Comment" and not "Approve" probably because it's my own PR... 😄

scripts/variantstore/docs/aou/AOU_DELIVERABLES.md Outdated Show resolved Hide resolved
scripts/variantstore/docs/aou/AOU_DELIVERABLES.md Outdated Show resolved Hide resolved
- Run the steps in the notebook:
- In section 1.2, Set the `sample_list_file_path` variable in that notebook to the path of the file
- Run the cells up to and through, section 1.4 ("Perform the copy, in batches")
- If you want to automatically break up the new samples into smaller sample sets, then run the "now that the data have been copied, you can make sample sets if you wish" step. Set the `SUBSET_SIZE` and `set_name` variables to customize.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this something we need to do and not really an "If"? Are there particular values that are known to work well for those variables?

Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 👍🏻

gbggrant and others added 3 commits October 24, 2023 14:12
Co-authored-by: Miguel Covarrubias <mcovarr@users.noreply.github.com>
Co-authored-by: Miguel Covarrubias <mcovarr@users.noreply.github.com>
@gbggrant gbggrant merged commit 0b4cb75 into ah_var_store Oct 24, 2023
7 of 13 checks passed
@gbggrant gbggrant deleted the vs_1073_aou_deliverables_doc branch October 24, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants