Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few additional failures to our notes doc #8980

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

RoriCremer
Copy link
Contributor

@RoriCremer RoriCremer commented Sep 15, 2024

no automated testing needed--just documentation edits

@rsasch rsasch self-requested a review September 26, 2024 13:58
Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some specific changes, also I think it would be useful to have a consistent way of attaching the failures to a specific workflow, sub-workflow and task for easier use.

scripts/variantstore/beta_docs/gvs-troubleshooting.md Outdated Show resolved Hide resolved
scripts/variantstore/beta_docs/gvs-troubleshooting.md Outdated Show resolved Hide resolved
scripts/variantstore/beta_docs/gvs-troubleshooting.md Outdated Show resolved Hide resolved
scripts/variantstore/beta_docs/gvs-troubleshooting.md Outdated Show resolved Hide resolved
scripts/variantstore/beta_docs/gvs-troubleshooting.md Outdated Show resolved Hide resolved
scripts/variantstore/beta_docs/gvs-troubleshooting.md Outdated Show resolved Hide resolved
scripts/variantstore/beta_docs/gvs-troubleshooting.md Outdated Show resolved Hide resolved
@RoriCremer
Copy link
Contributor Author

at some point in our notes we added 1. It is important to verify that the data has ALL made it into the BQ dataset or not but i'm not sure how to do this with Beta users or if it makes any sense at all

@RoriCremer RoriCremer marked this pull request as ready for review October 18, 2024 04:41
Copy link
Collaborator

@mcovarr mcovarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this PR, but it's a little concerning there are so many failure modes that require manual intervention

scripts/variantstore/beta_docs/gvs-troubleshooting.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@kbergin kbergin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry this took me SO long to review. Comments throughout.

scripts/variantstore/beta_docs/gvs-troubleshooting.md Outdated Show resolved Hide resolved
scripts/variantstore/beta_docs/gvs-troubleshooting.md Outdated Show resolved Hide resolved
scripts/variantstore/beta_docs/gvs-troubleshooting.md Outdated Show resolved Hide resolved
scripts/variantstore/beta_docs/gvs-troubleshooting.md Outdated Show resolved Hide resolved
scripts/variantstore/beta_docs/gvs-troubleshooting.md Outdated Show resolved Hide resolved
scripts/variantstore/beta_docs/gvs-troubleshooting.md Outdated Show resolved Hide resolved
scripts/variantstore/beta_docs/gvs-troubleshooting.md Outdated Show resolved Hide resolved
@kbergin
Copy link
Collaborator

kbergin commented Oct 22, 2024

Generally, could you add sections for failures in the other high level steps of GVS? Or if GVS fails in any step besides ingest does the user need to start over from scratch? It'd be great to indicate that ie "If your workflow fails in any step after ingest, unfortunately you will need to delete your BigQuery dataset and start from the beginning." ?

@RoriCremer RoriCremer requested a review from kbergin December 20, 2024 20:28
@RoriCremer RoriCremer merged commit 8d2a0bf into ah_var_store Jan 2, 2025
20 of 21 checks passed
@RoriCremer RoriCremer deleted the rc-1464-beta-failures branch January 2, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants