Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply hints suggested by the ruff linter #165

Merged
merged 16 commits into from
Oct 21, 2023
Merged

Conversation

btschwertfeger
Copy link
Owner

@btschwertfeger btschwertfeger commented Sep 9, 2023

Summary

Some more ruff rules were enabled which only affects/improves the unit tests.

Also the documentation was somewhat extended for the example scripts of this repositroy.

@btschwertfeger btschwertfeger added this to the v2.0.0 milestone Sep 9, 2023
@btschwertfeger btschwertfeger self-assigned this Sep 9, 2023
@btschwertfeger btschwertfeger added the Testing Test-related label Sep 9, 2023
@btschwertfeger btschwertfeger changed the base branch from master to v2 September 9, 2023 12:32
@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Merging #165 (f269b1b) into v2 (8072cb9) will not change coverage.
Report is 1 commits behind head on v2.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               v2     #165   +/-   ##
=======================================
  Coverage   90.52%   90.52%           
=======================================
  Files          21       21           
  Lines        1836     1836           
=======================================
  Hits         1662     1662           
  Misses        174      174           
Flag Coverage Δ
unittests 90.52% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
kraken/base_api/__init__.py 89.94% <100.00%> (ø)
kraken/exceptions/__init__.py 99.18% <ø> (ø)
kraken/futures/market.py 91.66% <ø> (ø)
kraken/futures/trade.py 96.20% <100.00%> (ø)
kraken/futures/websocket/__init__.py 78.61% <ø> (ø)
kraken/futures/ws_client.py 87.50% <100.00%> (ø)
kraken/spot/orderbook_v1.py 94.44% <ø> (ø)
kraken/spot/orderbook_v2.py 94.04% <100.00%> (ø)
kraken/spot/trade.py 94.33% <100.00%> (ø)
kraken/spot/user.py 99.12% <100.00%> (ø)
... and 2 more

@btschwertfeger btschwertfeger added the Documentation Improvements or additions to documentation label Sep 9, 2023
@btschwertfeger btschwertfeger merged commit aae3fe5 into v2 Oct 21, 2023
19 checks passed
@btschwertfeger btschwertfeger deleted the apply-ruff-hints branch October 21, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Testing Test-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant