Add testing.T arg to test-only helpers #6574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutable_stat_util.go is surprisingly mixed in its purpose, though it is not documented as such in any way I can see. So, since these kinda-dubious copy-helpers are in here but are not clearly test-only, I've added a testing.T arg to make it clear and prevent their use elsewhere. More cleanup should happen in this file, but they're all quite semantically different so I'm breaking it up.
Groxx
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
taylanisikdemir
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mutable_stat_util.go is surprisingly mixed in its purpose, though it is not documented as such in any way I can see.
So, since these kinda-dubious copy-helpers are in here but are not clearly test-only, I've added a testing.T arg to make it clear and prevent their use elsewhere.
More cleanup should happen in this file, but they're all quite semantically different so I'm breaking it up.