Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: don't fetch all the hosts #18319

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from
Draft

perf: don't fetch all the hosts #18319

wants to merge 28 commits into from
+48 −34

Conversation

Udit-takkar
Copy link
Contributor

@Udit-takkar Udit-takkar commented Dec 21, 2024 •
edited
Loading

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Testing if we need all the hosts.

Same event type with 1300+ hosts

BEFORE:-
Screenshot 2024-12-22 at 1 45 22 AM

AFTER:-
Screenshot 2024-12-22 at 1 44 41 AM

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • N/A I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Dec 21, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Dec 27, 2024 1:40pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Dec 27, 2024 1:40pm

@Udit-takkar Udit-takkar changed the title perf: don't fetch all the hosts perf: don't fetch all the hosts [DO NOT MERGE] Dec 21, 2024
@Udit-takkar Udit-takkar marked this pull request as ready for review December 21, 2024 20:32
@graphite-app graphite-app bot requested a review from a team December 21, 2024 20:32
@dosubot dosubot bot added the performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive label Dec 21, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 21, 2024 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/21/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (12/23/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@graphite-app graphite-app bot requested a review from a team December 23, 2024 07:51
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 23, 2024 •
edited
Loading

E2E results are ready!

@Udit-takkar Udit-takkar added this to the v4.9 milestone Dec 23, 2024
@Udit-takkar Udit-takkar added the high-risk Requires approval by Foundation team label Dec 24, 2024
@Udit-takkar Udit-takkar changed the title perf: don't fetch all the hosts [DO NOT MERGE] perf: don't fetch all the hosts Dec 26, 2024
@Udit-takkar Udit-takkar marked this pull request as draft December 27, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hariombalhara hariombalhara Awaiting requested review from hariombalhara

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO high-risk Requires approval by Foundation team performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive ready-for-e2e
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.
5 participants
@Udit-takkar @hariombalhara @keithwillcode @alishaz-polymath @anikdhabal