fix: include onLayout in TextInput render props #4239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewalczak
changed the title
|
Hey @AugustasFriend, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
lukewalczak
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Typescript definition are not up to date with the actual usages. TextInputOutlined uses this to measure the layout, but we have it optional since TextInputFlat doesn't pass it along.
react-native-paper/src/components/TextInput/TextInputOutlined.tsx
Line 377 in c190a95
react-native-paper/src/components/TextInput/TextInputFlat.tsx
Line 383 in c190a95
Test plan
Run typescript type check to verify it.