fix: eliminate a potential deadlock

camptocamp · Mar 21, 2020 · 3b0c332 · 3b0c332
1 parent 906242f
commit 3b0c332
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/main.go b/main.go
@@ -160,14 +160,16 @@ func runHelm() (errs []error) {
 					default:
 					}
 
-					cleartextSecretFile, err := os.OpenFile(cleartextSecretFilename, os.O_RDONLY, 0)
+					cleartextSecretFile, err := os.OpenFile(cleartextSecretFilename, os.O_RDWR, 0)
 
 					if err != nil {
 						*errs = append(*errs, fmt.Errorf("failed to open cleartext secret pipe '%s' in pipe closer: %s", cleartextSecretFilename, err))
 
 						return
 					}
 
+					<-pipeWriterUnlockedChannel
+
 					defer func() {
 						err := cleartextSecretFile.Close()