Skip to content

Commit

Permalink
fix: try to make kubeconfig variables available to crossclustercomm func
Browse files Browse the repository at this point in the history
  • Loading branch information
bkenez committed Jan 8, 2025
1 parent 00c6fb4 commit 1ebbd11
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion test/internal/helpers/kubectl/helpers.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ type ClusterInfo struct {
GatewayVersion string `json:"gatewayVersion"`
}

func CrossClusterCommunication(t *testing.T, withDNS bool, k8sManifests string, primary, secondary helpers.Cluster) {
func CrossClusterCommunication(t *testing.T, withDNS bool, k8sManifests string, primary, secondary helpers.Cluster, kubeConfigPrimary, kubeConfigSecondary string) {
kubeResourcePath := fmt.Sprintf("%s/%s", k8sManifests, "nginx.yml")

if withDNS {
Expand Down
7 changes: 5 additions & 2 deletions test/multi_region_aws_dns_chaining_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,9 @@ func clusterReadyCheck(t *testing.T) {

func testCrossClusterCommunication(t *testing.T) {
t.Log("[CROSS CLUSTER] Testing cross-cluster communication with IPs 📡")
kubectlHelpers.CrossClusterCommunication(t, false, k8sManifests, primary, secondary)
t.Run("TestInitKubernetesHelpers", initKubernetesHelpers)

kubectlHelpers.CrossClusterCommunication(t, false, k8sManifests, primary, secondary, kubeConfigPrimary, kubeConfigSecondary)
}

func applyDnsChaining(t *testing.T) {
Expand All @@ -101,5 +103,6 @@ func testCoreDNSReload(t *testing.T) {

func testCrossClusterCommunicationWithDNS(t *testing.T) {
t.Log("[CROSS CLUSTER] Testing cross-cluster communication with DNS 📡")
kubectlHelpers.CrossClusterCommunication(t, true, k8sManifests, primary, secondary)
t.Run("TestInitKubernetesHelpers", initKubernetesHelpers)
kubectlHelpers.CrossClusterCommunication(t, false, k8sManifests, primary, secondary, kubeConfigPrimary, kubeConfigSecondary)
}

0 comments on commit 1ebbd11

Please sign in to comment.