deps: update modeling deps #3959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marstamm
requested review from
philippfromme and
barmac
and removed request for
a team
marstamm
commented
Nov 2, 2023
marstamm
force-pushed
the
housekeeping
branch
from
47c87cb to
435067d
Compare
|
@marstamm we just released |
|
As I understand it, this change - @import '~@camunda/form-playground/dist/assets/form-js-editor.css';
+ @import '~@camunda/form-playground/dist/assets/form-js-editor-base.css';
+ @import '~@camunda/form-playground/dist/assets/dragula.css';also prevents us from loading the properties-panel.css twice. I think we want to keep this, as it also prevents possible css clashes in the future and makes debugging easier. |
|
Yes, definitely a good thing to do 👍 |
nikku
reviewed
Nov 6, 2023
marstamm
force-pushed
the
housekeeping
branch
from
435067d to
8d97b29
Compare
|
Not intended, I changed the commit message with 8d97b29 |
nikku
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3929, closes #3884, closes #3941