Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependency electron to v30 #4246

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 16, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
electron ^29.0.0 -> ^30.0.0 age adoption passing confidence

Release Notes

electron/electron (electron)

v30.0.0

Compare Source

v29.3.0: electron v29.3.0

Compare Source

Release Notes for v29.3.0

Fixes

  • Fixed a bug where a window with maximization disabled and WCO enabled would still show its maximization button. #​41807

Other Changes

v29.2.0: electron v29.2.0

Compare Source

Release Notes for v29.2.0

Fixes

  • Fixed crash in Notification::Close() under libnotify 0.8.x with portal environment. #​41707 (Also in 28, 30)
  • Fixed usage of Storage.{get|set|clear}Cookies via the Chrome DevTools Protocol. #​41739 (Also in 28, 30)

Other Changes

Documentation

Unknown

  • Added support for Bluetooth ports being requested by service class ID in navigator.serial. #​41735 (Also in 30)

v29.1.6: electron v29.1.6

Compare Source

Release Notes for v29.1.6

Fixes

  • Fixed shell.showItemInFolder not opening Windows Explorer if the passed path contains forward slashes. #​41672 (Also in 28, 30)
  • Fixed a potential crash in chrome.scripting on extension unload. #​41701 (Also in 30)
  • Fixed an issue where emojis weren't properly handled on Windows. #​41680 (Also in 30)
  • Fixed an issue where the serial-port-added event improperly respected filters set by serial.requestPort(). #​41636 (Also in 28, 30)

Other Changes

v29.1.5: electron v29.1.5

Compare Source

Release Notes for v29.1.5

Fixes

  • Fixed an issue where badge text set using the Badging API no longer appeared correctly on Windows. #​41628 (Also in 30)

Other Changes

  • Updated Chromium to 122.0.6261.130. #​41598

v29.1.4: electron v29.1.4

Compare Source

Release Notes for v29.1.4

Other Changes

  • Updated Chromium to 122.0.6261.129. #​41583

v29.1.3: electron v29.1.3

Compare Source

Release Notes for v29.1.3

Fixes

  • Fixed chrome://process-internals failing to load. #​41542 (Also in 28, 30)
  • Fixed a memory corruption crash on Windows by removing DXDiag telemetry code. #​41574

Other Changes

v29.1.2: electron v29.1.2

Compare Source

Release Notes for v29.1.2

Fixes

  • Fixed chrome://process-internals failing to load. #​41542 (Also in 28, 30)
  • Fixed a memory corruption crash on Windows by removing DXDiag telemetry code. #​41574

Other Changes

v29.1.1: electron v29.1.1

Compare Source

Release Notes for v29.1.1

Fixes

  • Fixed an issue where user-did-{resign|become}-active were not emitted properly on macOS. #​41527 (Also in 28, 30)
  • Fixed an issue where webContents.print(options) failed if options was not passed or undefined is passed. #​41479 (Also in 28, 30)

Other Changes

  • Updated Chromium to 122.0.6261.95. #​41489

v29.1.0: electron v29.1.0

Compare Source

Release Notes for v29.1.0

Features

  • Added proxy configuring support for requests made with net module from utility process. #​41416 (Also in 30)

Fixes

  • Ensured ScreenCaptureKit is used exclusively on macOS 14.4 and higher to avoid permission prompts. #​41403 (Also in 30)

Other Changes

  • Updated Chromium to 122.0.6261.70. #​41446

Configuration

📅 Schedule: Branch creation - "after 10pm,before 5:00am" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Updates a dependency label Apr 16, 2024
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Apr 16, 2024
@nikku
Copy link
Member

nikku commented Apr 18, 2024

Works on Linux ✔️.

@barmac
Copy link
Collaborator

barmac commented Apr 18, 2024

On Mac:

  • npm start works
  • npm run build works; both mac and mac64 executables work

@barmac
Copy link
Collaborator

barmac commented Apr 18, 2024

On my machine, I had to add the following snippet to the distro job, otherwise the build script failed on code signing. But it can as well be a problem with my local setup. We should not disallow to sign local builds.

// disable local signing on mac
if (!publish) {
  signingOptions.push('-c.mac.identity=null');
}

@barmac
Copy link
Collaborator

barmac commented Apr 18, 2024

Interesting: This release adds support for NODE_EXTRA_CA_CERTS variable which provides some configuration for custom certificates (electron/electron#41590).

@nikku
Copy link
Member

nikku commented Apr 18, 2024

We should not disallow to sign local builds.

I don't quite understand this: Do you think we shall add this line (only sign during publish) or do you want to have signing as part of the default build pipeline?

I think it is expected for signing to fail locally, if relevant certs are not present.

@barmac
Copy link
Collaborator

barmac commented Apr 18, 2024

I think we should not add this line, and I should fix my local setup.

@nikku nikku requested review from philippfromme and barmac April 19, 2024 06:21
@barmac
Copy link
Collaborator

barmac commented Apr 19, 2024

@philippfromme it will be great if you can check this out on Windows.

@nikku nikku merged commit e65f7c8 into develop Apr 19, 2024
16 checks passed
@nikku nikku deleted the renovate/electron-30.x branch April 19, 2024 16:44
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Updates a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants