Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate new context pad #4321

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Integrate new context pad #4321

merged 2 commits into from
Jun 3, 2024

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented May 29, 2024 •
edited by nikku
Loading

Adds the ability to enable the new context pad through the enable-new-context-pad flag.

electron_RvzZDnvUz7

Related to #4263

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label May 29, 2024
@philippfromme philippfromme marked this pull request as ready for review May 29, 2024 12:51
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels May 29, 2024
@philippfromme philippfromme requested review from barmac, nikku and marstamm and removed request for barmac May 29, 2024 12:51
@nikku nikku force-pushed the new-context-pad branch from cfc8fa8 to 85f1df8 Compare May 29, 2024 12:59
nikku
nikku reviewed May 29, 2024
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'd remove the background to better fit into the existing desktop modeler design:

capture D7PMEC_optimized

@philippfromme philippfromme requested a review from nikku May 29, 2024 13:44
@philippfromme
Copy link
Contributor Author

@nikku I changed the background to white.

@philippfromme philippfromme marked this pull request as draft May 29, 2024 13:51
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels May 29, 2024
@philippfromme
Copy link
Contributor Author

Forgot to add to dmn-js.

@nikku
Copy link
Member

nikku commented May 29, 2024

As discussed we don't have comments in the core modeling domain and would need to get rid of them:

image

@philippfromme philippfromme marked this pull request as ready for review May 31, 2024 07:36
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels May 31, 2024
@nikku
Copy link
Member

nikku commented Jun 3, 2024

@philippfromme I assume this closes #4263?

If so, let's tag this PR accordingly.

@nikku nikku mentioned this pull request Jun 3, 2024
Closed
2 tasks
nikku
nikku approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 👏

@nikku nikku merged commit be1e669 into develop Jun 3, 2024
13 checks passed
@nikku nikku deleted the new-context-pad branch June 3, 2024 09:21
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

@barmac barmac Awaiting requested review from barmac

@marstamm marstamm Awaiting requested review from marstamm

Assignees

@philippfromme philippfromme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippfromme @nikku