chore: use @axe-core/react in dev
#4358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barmac
requested review from
a team,
philippfromme and
marstamm
and removed request for
a team
|
Could you share additional context what this accomplishes? Cf. bpmn-io/.github#7. |
|
Yes! I will add a screenshot. |
|
Screenshot added. The strong point of this tool is that it continuously scans the application in contrast to the chrome extension which has to be run manually. So we can click around, and then collect the reports. We could also wrap it in a Desktop Modeler plugin, but for that we'd need to expose ReactDOM on the window. That could be useful though during the integration tests. Otherwise, we'd need to |
nikku
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Looks great. Let's add it to "implemented measures" in https://github.com/bpmn-io/internal-docs/issues/909.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dev tool should help us to identify accessibility issues. We will need to drop it with React 18 upgrade (some day...), but until then it should be useful.
Related to https://github.com/bpmn-io/internal-docs/issues/909