Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: make curl fail on unsuccessful call to slack API #4418

Merged
merged 1 commit into from
Jul 3, 2024
Merged

ci: make curl fail on unsuccessful call to slack API #4418

merged 1 commit into from
Jul 3, 2024

Conversation

barmac
Copy link
Collaborator

@barmac barmac commented Jul 3, 2024

Closes #4417

Proposed Changes

This PR makes us use curl --fail-with-body so that when API call fails, the action fails too.

Cf. https://superuser.com/questions/590099/can-i-make-curl-fail-with-an-exitcode-different-than-0-if-the-http-status-code-i

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@barmac barmac requested review from a team, philippfromme and marstamm and removed request for a team July 3, 2024 07:57
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jul 3, 2024
Copy link
Member

@marstamm marstamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try it out

@nikku nikku merged commit dc2f94d into develop Jul 3, 2024
15 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 3, 2024
@nikku nikku deleted the curl branch July 3, 2024 08:22
@github-actions github-actions bot added this to the M79 milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release manager slack sync is broken
3 participants