Populate empty tab buttons from available create options

[marstamm]

Proposed Changes

related to #4568

I noticed that with the plugin, the new file dialog from the OS menu does not work. Start page and client side new-tab worked, as we added the special action handling there.

With this change, we allow action and options to be an array for #triggerAction, so menu actions can easily add options, even when triggered via a backend module.

Try it out:

• Download RPA Plugin here: http://github.com/camunda/camunda-modeler-rpa-plugin/zipball/latest/
• add it as a plugin
• try to open a new .robot file from the file menu
• It now works

Checklist

To ensure you provided everything we need to look at your PR:

• Brief textual description of the changes present
• Visual demo attached
• Steps to try out present, i.e. using the @bpmn-io/sr tool
• Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

[github-actions]

This Pull Request targets develop branch, but contains fix commits.

Consider targeting main instead.

[nikku]

Get rid of this

Suggested change

	console.log(action, options);
	console.log(action, options);

[marstamm]

🤦

Fixed in 88646ed

[nikku]

Could you elaborate what exactly is missing from the current way to trigger menus?

I verified via 1163371 and e53e2f3 to see that we can already pass context.

I propose that we update the existing examples / plug-ins to feature the new extension point / usage patterns within the DEV environment. This makes it simpler for you to test things, but also allows us to verify that we don't break E2E scenarios in the future.

[marstamm]

You are right, this is not the correct way to implement this. The problem is that we use the tab provider both the frontend (right plus button) as well as the backend (File menu).

The Frontend implementation does not support adding options, the backend does. This needs to be fixed in the frontend code that renders the Menu, as well as add the option for "options" in the Slot on the front page. I will revisit this PR

[marstamm]

I adjusted the code to accept options for triggered actions and added a simple sample tab plugin that shows a hello world page.

With this change, you can open new Tabs and trigger events properly from all places we need them

[nikku]

The Frontend implementation does not support adding options, the backend does. This needs to be fixed in the frontend code that renders the Menu, as well as add the option for "options" in the Slot on the front page. I will revisit this PR

What we could consider for a good integration:

• Render + and options based off registered tab providers.
• Ensures that UX is always decent (i.e. we could hide ROBOT and friends behind a ... on the landing page
• New file types are always represented in all relevant areas, just because they are registered.

The current way of doing things is error-prone.

[marstamm]

Render + and options based off registered tab providers.

We already do this

hide ROBOT and friends behind a ... on the landing page

I would not hide them, we have enough space on the landing page and I do not see us having a lot of additional Providers. If we get to the point, we can reiterate and hide them.

New file types are always represented in all relevant areas, just because they are registered.

The only place we do not do that yet is the Welcome page. I added this in 7ee2c34

[nikku]

7ee2c34 is great, because it sets us up to do whatever optimizations on the welcome page in the future. Good stuff.

[nikku]

I struggled to get this up and running just to realize that we did not check-in the test-plugin distro (as we do with other distributions). Fixed via d1f280b.

Then I checked the welcome page designs. Via 016fe71 I made sure that the UI scales, independent on how many options we offer.

The overall changes look good to me.

[nikku]

You could do another round of cleanup on the commit history, but otherwise it looks good to merge.

[marstamm]

Also noticed that we need key attribute on the Button elements so React plays nicely. Will make the adjustments and squash the commits

[marstamm]

I did a small refactoring in EmptyTab to add key to the dynamically rendered buttons and squashed the commits. Please have a final look at the refactoring :)

[nikku]

It seems like the new way of declaring the EmptyTab is incompatible with our ref-based approach, cf. errors thrown in the developer console:

[marstamm]

Fixed via 24e086a. As the functions called on the ref are all implemented by the child, we are fine to simply forward the ref to the EmptyTab component.

[nikku]

Thanks for the update.

The change still did not fully work, as triggerAction in your proposed fix was not implemented on the HelloWorld tab. What I propose instead is to implement a proper tab there: 45be9f0. This allows us to work with the HellowWorld tab without problems.

[nikku]

Once CI passes I'll squash the changes and merge this PR. 🎉