Export images with webhook icon #4576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barmac
requested review from
a team,
marstamm and
jarekdanielak
and removed request for
a team
nikku
reviewed
Oct 1, 2024
client/package.json
Outdated
| @@ -67,6 +67,7 @@ | |||
| "scroll-tabs": "^1.0.1", | |||
| "semver-compare": "^1.0.0", | |||
| "sourcemapped-stacktrace": "^1.1.11", | |||
| "tiny-svg": "^3.1.3", | |||
There was a problem hiding this comment.
Suggested change
| "tiny-svg": "^3.1.3", | |
| "tiny-svg": "^3.1.3", |
Should we not just npm update tiny-svg to update the dependency (nested)?
There was a problem hiding this comment.
Feels odd to introduce this here (unless we use it within the modeler).
There was a problem hiding this comment.
(We do use it, but it is pulled in through bpmn-js, so I'd expect to simply bump the nested dependency).
There was a problem hiding this comment.
I pulled it because we directly depend on it. I should've commented on that.
deps: update to `tiny-svg@3.1.3` Closes #4127
nikku
force-pushed
the
4127-update-tiny-svg
branch
from
9848ff9 to
0a87b4f
Compare
nikku
approved these changes
Oct 1, 2024
client/package.json
Outdated
| @@ -67,6 +67,7 @@ | |||
| "scroll-tabs": "^1.0.1", | |||
| "semver-compare": "^1.0.0", | |||
| "sourcemapped-stacktrace": "^1.1.11", | |||
| "tiny-svg": "^3.1.3", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tiny-svg@3.1.3Closes #4127
Screen.Recording.2024-10-01.at.17.18.11.mov
Proposed Changes
This updates tiny-svg and also includes it in the dependencies as we already use it in the source code: https://github.com/camunda/camunda-modeler/blob/develop/client/src/app/tabs/dmn/modeler/features/overview/overview-renderer/OverviewRenderer.js#L28
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/srtoolCloses {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}