Fix CC1Main setting trigger undefined behavior #4714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is caused by setting a temporary lambda to a llvm::function_ref. The fix is to avoid using a lambda and define a function instead.
This is caused by setting a temporary lambda to a `llvm::function_ref`. The fix is to assign the lambda into `std::function` that outlives the `llvm::function_ref`.
jonmeow
approved these changes
Dec 19, 2024
| @@ -146,13 +146,15 @@ auto ClangRunner::Run(llvm::ArrayRef<llvm::StringRef> args) -> bool { | |||
| // Note the subprocessing will effectively call `clang -cc1`, which turns into | |||
| // `carbon-busybox clang -cc1`, which results in an equivalent `clang_main` | |||
| // call. | |||
| driver.CC1Main = [](llvm::SmallVectorImpl<const char*>& cc1_args) -> int { | |||
| std::function<int(llvm::SmallVectorImpl<const char*> & cc1_args)> cc1_main = | |||
There was a problem hiding this comment.
Suggested change
| std::function<int(llvm::SmallVectorImpl<const char*> & cc1_args)> cc1_main = | |
| auto cc1_main = |
Does this need to explicitly be a std::function, or is it enough to store the lambda directly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is caused by setting a temporary lambda to a
llvm::function_ref.The fix is to assign the lambda into
std::functionthat outlives thellvm::function_ref.