Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify the logic for invalid impl redeclarations #4738

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Clarify the logic for invalid impl redeclarations #4738

merged 1 commit into from
Dec 23, 2024

Conversation

josh11b
Copy link
Contributor

@josh11b josh11b commented Dec 23, 2024

Follow up to #4179, specifically re: #4719 (comment) .

@josh11b josh11b requested a review from danakj December 23, 2024 19:19
@github-actions github-actions bot requested a review from jonmeow December 23, 2024 19:19
danakj
danakj approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@danakj danakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This helps a lot

@josh11b josh11b mentioned this pull request Dec 23, 2024
Merged
@josh11b josh11b added this pull request to the merge queue Dec 23, 2024
Merged via the queue into carbon-language:trunk with commit 1a5107e Dec 23, 2024
10 checks passed
@josh11b josh11b deleted the rename branch December 23, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danakj danakj danakj approved these changes

@jonmeow jonmeow Awaiting requested review from jonmeow

Assignees
No one assigned
Labels
toolchain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josh11b @danakj