[ADP-3335] Add functions and mock implementations to Deposit Wallet #4527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeinrichApfelmus
changed the base branch from
master
to
HeinrichApfelmus/ADP-3335/deposit-wallet-db
HeinrichApfelmus
changed the title
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3335/mock-deposit
branch
from
de236a9 to
b16bb0b
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3335/mock-deposit
branch
from
b16bb0b to
5608d1e
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3335/deposit-wallet-db
branch
from
09d294a to
4bd8b0b
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3335/mock-deposit
branch
from
5608d1e to
a1b11fa
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3335/deposit-wallet-db
branch
from
4bd8b0b to
f06018b
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3335/mock-deposit
branch
from
a1b11fa to
418a80f
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3335/deposit-wallet-db
branch
from
f06018b to
d1d58af
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3335/mock-deposit
branch
from
418a80f to
e76c26a
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3335/deposit-wallet-db
branch
from
d1d58af to
0e05b55
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3335/mock-deposit
branch
from
e76c26a to
cc51cf6
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3335/deposit-wallet-db
branch
from
0e05b55 to
da599d2
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3335/mock-deposit
branch
from
cc51cf6 to
ce2a99a
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3335/deposit-wallet-db
branch
from
da599d2 to
4d683d0
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3335/mock-deposit
branch
from
ce2a99a to
2d4cf2a
Compare
HeinrichApfelmus
requested review from
paweljakubas
and removed request for
paolino
| @@ -50,6 +55,9 @@ import Data.Foldable | |||
| import Data.List.NonEmpty | |||
| ( NonEmpty | |||
| ) | |||
| import Data.Map | |||
There was a problem hiding this comment.
my suggestion: use Data.Map.Strict
There was a problem hiding this comment.
Is it needed when importing the type Map rather than the functions? But maybe the Semigroup instance… 🤔
| @@ -59,6 +60,7 @@ import qualified Cardano.Wallet.Primitive.Types.Tx.TxIn as W | |||
| import qualified Cardano.Wallet.Primitive.Types.Tx.TxOut as W | |||
| import qualified Cardano.Wallet.Primitive.Types.UTxO as W | |||
| import qualified Data.ByteString as BS | |||
| import qualified Data.ByteString.Char8 as B8 | |||
| -- import qualified Ouroboros.Consensus.Cardano.Block as O | |||
There was a problem hiding this comment.
I hope we will clean those things later... Now, not a good moment?
There was a problem hiding this comment.
Yes. Cardano.Wallet.Deposit.Read is essentially a messy lumber room at the moment. 😅
paweljakubas
approved these changes
May 10, 2024
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3335/deposit-wallet-db
branch
from
4d683d0 to
f186998
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3335/mock-deposit
branch
from
2d4cf2a to
02078e9
Compare
|
Thanks for your review, Pawel! 😊
Not yet. The next pull request, #4513, will specify usage scenarios and (mock) test some of these scenarios. The methods will be mainly tested on the |
Base automatically changed from
HeinrichApfelmus/ADP-3335/deposit-wallet-db
to
master
May 13, 2024 17:34
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3335/mock-deposit
branch
from
02078e9 to
1c697ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds various functions and mock implementations to the Deposit Wallet in order to prepare the execution of user scenarios.
Comment
This pull request prepares the implementation of a mock environment for
the Deposit Wallet. In turn, this enables execution of user scenarios.
Issue Number
ADP-3335