[ADP-3350] Fix Cardano.Wallet.Read.Block.SlotNo
#4535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanknowles
approved these changes
Apr 15, 2024
Comment on lines
+68
to
+70
| deriving (Eq, Ord, Show, Generic) | ||
|
|
||
| instance NoThunks SlotNo |
There was a problem hiding this comment.
This could be shortened to:
Suggested change
| deriving (Eq, Ord, Show, Generic) | |
| instance NoThunks SlotNo | |
| deriving stock (Eq, Ord, Show, Generic) | |
| deriving anyclass NoThunks |
There was a problem hiding this comment.
… but this is only shorter if you don't count the lines
{-# LANGUAGE DerivingStrategies #-}
{-# LANGUAGE DeriveAnyClass #-}that would have to be added at the top of the file. 🤓
I prefer to keep this code as is, as the intent is clear. In general, I only support new language extensions
- if they provide value with a good value/cost ratio
- and if they are established as part of the "team dialect of Haskell". (mental load)
paolino
requested changes
Apr 15, 2024
| @@ -56,6 +56,8 @@ import qualified Ouroboros.Consensus.Shelley.Ledger as O | |||
| type ConsensusBlock = O.CardanoBlock O.StandardCrypto | |||
|
|
|||
| -- Family of era-specific block types | |||
| -- TODO: The results of this type family should be ledger types, | |||
There was a problem hiding this comment.
Can we avoid TODOs without a ticket attached ?
There was a problem hiding this comment.
Fair enough. I have created ADP-3351 to track this, and recorded it here.
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3350/fix-slotno
branch
from
c3825df to
c81fb4f
Compare
paolino
approved these changes
Apr 15, 2024
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3350/fix-slotno
branch
from
c81fb4f to
82d1b6c
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the
Cardano.Wallet.Read.Block.SlotNomodule which encountered some difficulties with type class resolution and orphan instances, to the point where I suspected a compiler bug.I have also added
NoThunksandGenericinstances for theCardano.Wallet.Read.SlotNotype in preparation for future pull requests.Issue Number
Discovered during ADP-3350