-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADP-3272] Clarify Arbitrary
instance for PartialTx
.
#4536
Merged
jonathanknowles
merged 13 commits into
master
from
jonathanknowles/adp-3272/partial-tx-records
Apr 15, 2024
Merged
[ADP-3272] Clarify Arbitrary
instance for PartialTx
.
#4536
jonathanknowles
merged 13 commits into
master
from
jonathanknowles/adp-3272/partial-tx-records
Apr 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanknowles
changed the title
Revise
Clarify Apr 15, 2024
Arbitrary
instance for PartialTx
.Arbitrary
instance for PartialTx
.
Inline definition of `o`.
jonathanknowles
force-pushed
the
jonathanknowles/adp-3272/partial-tx-records
branch
from
April 15, 2024 06:00
7440814
to
10f5f9b
Compare
paolino
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 15, 2024
Merging manually, as:
|
jonathanknowles
changed the title
Clarify
[ADP-3272] Clarify Apr 15, 2024
Arbitrary
instance for PartialTx
.Arbitrary
instance for PartialTx
.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
ADP-3272
Description
This PR clarifies the
Arbitrary
instance forPartialTx
, making the following small improvements:PartialTx
:timelockKeyWitnessCounts = mempty
is (arguably) more self-documenting thanmempty
as a positional argument.extraUTxO
matches the field name used inPartialTx
.extraUTxO
is generated exclusively from the result of generating atx
.