Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADP-3272] Clarify Arbitrary instance for PartialTx. #4536

Merged
merged 13 commits into from
Apr 15, 2024

Conversation

jonathanknowles
Copy link
Contributor

@jonathanknowles jonathanknowles commented Apr 15, 2024

Issue

ADP-3272

Description

This PR clarifies the Arbitrary instance for PartialTx, making the following small improvements:

  • Use of explicit field names when constructing a PartialTx:
    • timelockKeyWitnessCounts = mempty is (arguably) more self-documenting than mempty as a positional argument.
  • Use of consistent terminology:
    • extraUTxO matches the field name used in PartialTx.
  • Clearer data flow:
    • It's (arguably) clearer that the extraUTxO is generated exclusively from the result of generating a tx.

@jonathanknowles jonathanknowles self-assigned this Apr 15, 2024
@jonathanknowles jonathanknowles changed the title Revise Arbitrary instance for PartialTx. Clarify Arbitrary instance for PartialTx. Apr 15, 2024
@jonathanknowles jonathanknowles force-pushed the jonathanknowles/adp-3272/partial-tx-records branch from 7440814 to 10f5f9b Compare April 15, 2024 06:00
Copy link
Collaborator

@paolino paolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@jonathanknowles jonathanknowles added this pull request to the merge queue Apr 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 15, 2024
@jonathanknowles jonathanknowles added this pull request to the merge queue Apr 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 15, 2024
@jonathanknowles
Copy link
Contributor Author

Merging manually, as:

@jonathanknowles jonathanknowles merged commit e7fc10b into master Apr 15, 2024
3 checks passed
@jonathanknowles jonathanknowles deleted the jonathanknowles/adp-3272/partial-tx-records branch April 15, 2024 07:06
@jonathanknowles jonathanknowles changed the title Clarify Arbitrary instance for PartialTx. [ADP-3272] Clarify Arbitrary instance for PartialTx. Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants