[ADP-3350] Add Read.ChainTip
type
#4541
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a data type
ChainTip
to theCardano.Wallet.Read
hierarchy.This type
ChainTip
is used in the ChainSync protocol to advertise the tip of the server's chain. It combines the information of aChainPoint
with aBlockNo
.This pull requests also adds
ouroboros-consensus
for the networking layerComments
NetworkLayer
currently uses theBlockHeader
type for advertising the tip of the chain. However, this is strictly speaking incorrect, as theBlockHeader
also includes a reference to the previous block header, whichChainTip
does not. In the legacy code, we currently invent a value out of thin air — the new typeChainTip
is more correct.NetworkLayer
interface to useRead.ChainPoint
andRead.ChainTip
.Issue Number
ADP-3350