Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move many Write.Tx.BalanceSpec tests to Conway #4762

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Move many Write.Tx.BalanceSpec tests to Conway #4762

wants to merge 1 commit into from
+253 −253

Conversation

Anviking
Copy link
Member

@Anviking Anviking commented Aug 31, 2024 •
edited
Loading

  • Move most unit tests to Conway
    • Sanity check updates to goldens
  • Fix PParam golden
  • Use IsRecentEra era instead of hardcoded eras

Fixes #4882

@Anviking Anviking self-assigned this Aug 31, 2024
@Anviking Anviking force-pushed the anviking/ADP-3413/balanceTx-unit-conway branch from 221fb21 to 71ded94 Compare August 31, 2024 17:45
@abailly
Copy link
Collaborator

abailly commented Dec 11, 2024

Is still relevant?

@Anviking
Copy link
Member Author

This should be done. I've created #4882 for proper scheduling. Closing this PR for now.

@Anviking Anviking closed this Dec 12, 2024
@Anviking Anviking mentioned this pull request Dec 12, 2024
Open
@Anviking Anviking reopened this Jan 7, 2025
@Anviking Anviking force-pushed the anviking/ADP-3413/balanceTx-unit-conway branch from 71ded94 to 6b4f15c Compare January 7, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Anviking Anviking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update remaining balanceTx unit and property tests to Conway
2 participants
@Anviking @abailly