-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Windows E2E tests on buildkite #4897
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly
force-pushed
the
abailly/buildkite-windows
branch
18 times, most recently
from
January 2, 2025 16:55
d2723fb
to
045afc4
Compare
paolino
force-pushed
the
abailly/buildkite-windows
branch
from
January 2, 2025 18:19
045afc4
to
f91a1cd
Compare
abailly
force-pushed
the
abailly/buildkite-windows
branch
3 times, most recently
from
January 3, 2025 11:19
8b719de
to
3355d90
Compare
* Replace the use of unreliable csnapshots.io with custom made snapshot hosted on AWS S3 * Trim down run tests to a handful
* Configure ruby * Download and unpack custom snapshot from S3 * Run some Ruby E2E tests * Document windows configuration
abailly
force-pushed
the
abailly/buildkite-windows
branch
from
January 3, 2025 14:57
1b3c1bc
to
aaaef23
Compare
paweljakubas
reviewed
Jan 3, 2025
paweljakubas
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
paolino
approved these changes
Jan 3, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 3, 2025
Co-authored-by: Pawel Jakubas <pawel.jakubas@iohk.io>
And ensure it runs only on RELEASE_CANDIDATE
### changes - Create windows check group in the main CI pipeline - Move windows E2E tests in the group - Add windows unit tests to it - Eliminate GH workflow for unit tests - Eliminate the rc-latest tag creation - Eliminate GH workflow for windows E2E ### notes - the launcher tests were already failing completely on the github workflow, I avoided to replicate the "tolerate failures" step in buildkite #4896
@paolino shouldn't this PR be closed? It's superseded by your other PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses part of #4896 by configuring steps in the buildkite pipeline to run (some of) our Ruby E2E tests:
preprod
network snapshotThese pipeline steps depend on the Windows build cross compiled by nix on Linux machines.
The existing GHA workflow to run E2E tests has also been fixed so the last item on the issue is still pending.
#4896