Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Windows E2E tests on buildkite #4897

Closed
wants to merge 13 commits into from
Closed

Conversation

abailly
Copy link
Collaborator

@abailly abailly commented Jan 2, 2025

This PR addresses part of #4896 by configuring steps in the buildkite pipeline to run (some of) our Ruby E2E tests:

  • Configure ruby code
  • Download, unpack, and prepare a preprod network snapshot
  • Run Shelley stake pool tests

These pipeline steps depend on the Windows build cross compiled by nix on Linux machines.
The existing GHA workflow to run E2E tests has also been fixed so the last item on the issue is still pending.

#4896

@abailly abailly force-pushed the abailly/buildkite-windows branch 18 times, most recently from d2723fb to 045afc4 Compare January 2, 2025 16:55
@paolino paolino force-pushed the abailly/buildkite-windows branch from 045afc4 to f91a1cd Compare January 2, 2025 18:19
@abailly abailly force-pushed the abailly/buildkite-windows branch 3 times, most recently from 8b719de to 3355d90 Compare January 3, 2025 11:19
@abailly abailly changed the title Trigger build on windows Run Windows E2E tests on buildkite Jan 3, 2025
* Replace the use of unreliable csnapshots.io with custom made
snapshot hosted on AWS S3
* Trim down run tests to a handful
* Configure ruby
* Download and unpack custom snapshot from S3
* Run some Ruby E2E tests
* Document windows configuration
@abailly abailly force-pushed the abailly/buildkite-windows branch from 1b3c1bc to aaaef23 Compare January 3, 2025 14:57
@abailly abailly marked this pull request as ready for review January 3, 2025 14:58
@abailly abailly requested a review from paolino January 3, 2025 14:58
.buildkite/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@paolino paolino added this pull request to the merge queue Jan 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 3, 2025
abailly and others added 9 commits January 4, 2025 09:35
Co-authored-by: Pawel Jakubas <pawel.jakubas@iohk.io>
And ensure it runs only on RELEASE_CANDIDATE
### changes 

- Create windows check group in the main CI pipeline
- Move windows E2E tests in the group 
- Add windows unit tests to it 
- Eliminate GH workflow for unit tests
- Eliminate the rc-latest tag creation 
- Eliminate GH workflow for windows E2E 

### notes
- the launcher tests were already failing completely on the github
workflow, I avoided to replicate the "tolerate failures" step in
buildkite

#4896
@paolino paolino added the CI CI related label Jan 5, 2025
@abailly
Copy link
Collaborator Author

abailly commented Jan 5, 2025

@paolino shouldn't this PR be closed? It's superseded by your other PR

@abailly abailly closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants