Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to output bump diff failure reason in ci #4906

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Make sure to output bump diff failure reason in ci #4906

merged 1 commit into from
Jan 7, 2025

Conversation

Anviking
Copy link
Member

@Anviking Anviking commented Jan 7, 2025 •
edited
Loading

Example ci output

<head></head>
* Comparing the given definition file with the currently deployed one... done
--
  | Modified: POST /wallets/{walletId}/transactions-balance
  | Response modified: 403
  | Content type modified: application/json
  | [Breaking] Alternative removed: balance_tx_conflicting_networks
  | Removing a resource is always breaking unless it was deprecated before (breaking)
  | 🚨 Error: The command exited with status 1

@Anviking
Log bump diff output in ci script
1bf1506 
...so that we can see the failure reason. `pipefail` should preserve
failing exit codes.
@Anviking Anviking self-assigned this Jan 7, 2025
@Anviking Anviking force-pushed the anviking/log-bump-diff-output branch from 2ad5349 to 1bf1506 Compare January 7, 2025 11:50
@Anviking Anviking changed the title Log bump diff output in ci script Make sure to output bump diff failure reason in ci Jan 7, 2025
paolino
paolino approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@paolino paolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Anviking Anviking enabled auto-merge January 7, 2025 11:55
@Anviking Anviking added this pull request to the merge queue Jan 7, 2025
Merged via the queue into master with commit fa88d39 Jan 7, 2025
27 checks passed
@Anviking Anviking deleted the anviking/log-bump-diff-output branch January 7, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paolino paolino paolino approved these changes

Assignees

@Anviking Anviking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anviking @paolino