Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure restoration benchmarks do not interfere with microbenchmarks #4907

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Jan 7, 2025

Changes

  • Add benchmarks-history dependency to restoration benchmark steps

fix #4903

@paolino paolino self-assigned this Jan 7, 2025
@paolino paolino added Improvement Mark a PR as an improvement, for auto-generated CHANGELOG CI CI related labels Jan 7, 2025
@paolino paolino changed the base branch from master to paolino/4902/add-documentation-links-update-release-CI-step January 7, 2025 14:29
@paolino paolino marked this pull request as ready for review January 7, 2025 14:31
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from paolino/4902/add-documentation-links-update-release-CI-step to master January 7, 2025 14:51
@paolino paolino force-pushed the paolino/4903/make-sure-restoration-benchmarks-run-after-microbenchmarks branch from 71cc3b7 to 8f3fa1e Compare January 7, 2025 15:04
@paolino paolino merged commit 3333ebd into master Jan 7, 2025
7 of 18 checks passed
@paolino paolino deleted the paolino/4903/make-sure-restoration-benchmarks-run-after-microbenchmarks branch January 7, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI related Improvement Mark a PR as an improvement, for auto-generated CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure restoration benchmarks are not overlapping functional benchmarks
2 participants