Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase build parallelism on macOS #2759

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

kkarbowiak
Copy link
Contributor

According to this information, all the macOS runners have at least 3 cores, so it makes sense to increase the build parallelism to this number.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #2759 (ca1e2be) into devel (caffe79) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            devel    #2759   +/-   ##
=======================================
  Coverage   91.36%   91.36%           
=======================================
  Files         190      190           
  Lines        7855     7855           
=======================================
  Hits         7176     7176           
  Misses        679      679           

@horenmar
Copy link
Member

horenmar commented Nov 7, 2023

Thanks, but since the time I wrote these I learned a better way to do this (see review).

@janisozaur
Copy link
Contributor

While make is not as slow as some other build systems (cough msbuild cough), ninja is still faster and autodetects core count.

@horenmar horenmar merged commit b735dfc into catchorg:devel Nov 7, 2023
73 checks passed
@horenmar
Copy link
Member

horenmar commented Nov 7, 2023

I usually don't see ninja being faster in from-zero full builds (it is awesome for incremental dev builds though), and last time I tried it wasn't installed on the VMs by default so the build had to spend time installing it every time.

@janisozaur
Copy link
Contributor

It seems the GitHub team is indeed opposed to installing ninja by default: actions/runner-images#8348

@horenmar horenmar added the Development Issues related to further development of Catch2 label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development Issues related to further development of Catch2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants